Dep: Pin min required flytekit version in IAP plugin #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Grätz <[email protected]>
fg91
force-pushed
the
fg91/dep/pin-flytekit-in-iap-plugin
branch
from
47b94bc to
fbfddb2
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1878 +/- ##
=======================================
Coverage 55.05% 55.05%
=======================================
Files 296 296
Lines 22241 22241
Branches 3356 3356
=======================================
Hits 12244 12244
Misses 9834 9834
Partials 163 163 ☔ View full report in Codecov by Sentry. |
fg91
requested review from
cosmicBboy,
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The flytekit identity aware proxy plugin introduced in #1787 requires changes in flytekit's authentication logic which were introduced in the same PR. At the moment, the flytekit version is not pinned in the new plugin's
setup.pythough. In this PR I pin it to>=1.10, the next release that will contain those changes to the auth logic.Type
Are all requirements met?